Removed grouping functionality from front-end #37
Conversation
…e cycle Switching to and from comparison mode now triggers normal metadata update cycle, with api returning formated accounts data. The params-checkboxes settings directive also now only converts relevant data to metadata.
|
https://github.com/maestrano/impac/pull/102 |
|
When I unselect all the organizations to simulate a "data not found", I have this error: and the widget keeps loading |
|
when I select "compare matching accounts across your companies", it lets me select any account, and not only the accounts existing in the two companies
|
|
@cesar-tonnoir thanks for testing - those two bugs should be fixed, if you could give them another test on your environment and let me know. Cheers |
| @@ -22,43 +22,29 @@ module.controller('WidgetAccountsComparisonCtrl', ($scope, $q, ChartFormatterSvc | |||
| # -------------------------------------- | |||
| w.initContext = -> | |||
| $scope.isDataFound = w.content? && !_.isEmpty(w.content.complete_list) | |||
| # parameters for params-checkboxes.directive | |||
| # defines the available options for params-checkboxes.directive | |||
| $scope.comparisonModeOptions = [{ | |||
| id: 'compare_accounts', | |||
| label: 'Compare matching accounts across your companies', | |||
| value: false, | |||
| onChangeCallback: $scope.multiCompanyComparisonOnChange | |||
There was a problem hiding this comment.
@xaun: can be changed to "$scope.updateSettings()" instead of defining a new function
Removed grouping functionality from front-end
Switching to and from comparison mode now triggers normal metadata update cycle, with api returning formatted accounts data. The params-checkboxes settings directive also now only converts relevant data to metadata.